[ML] Cap graceful shutdown time #76342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The node shutdown work done in elastic#75188 did not impose any upper bound on the time allowed for ML jobs to shut down gracefully. This change imposes a cap of 10 minutes on shutdown time. In reality closing ML jobs shouldn't take this long, but we don't want ML to stall the shutdown process forever due to a bug, and require user intervention to recover.
|
Pinging @elastic/ml-core (Team:ML) |
|
|
benwtrent
approved these changes
Aug 11, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 11, 2021
The node shutdown work done in #75188 did not impose any upper bound on the time allowed for ML jobs to shut down gracefully. This change imposes a cap of 10 minutes on shutdown time. In reality closing ML jobs shouldn't take this long, but we don't want ML to stall the shutdown process forever due to a bug, and require user intervention to recover. Backport of #76342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The node shutdown work done in #75188 did not impose any
upper bound on the time allowed for ML jobs to shut down
gracefully.
This change imposes a cap of 10 minutes on shutdown time.
In reality closing ML jobs shouldn't take this long, but
we don't want ML to stall the shutdown process forever
due to a bug, and require user intervention to recover.