Add Fields API to aggregation scripts and field scripts #76325
Conversation
jdconrad
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
| @@ -140,6 +143,24 @@ | |||
| filter.add(filterWhitelist); | |||
| map.put(FilterScript.CONTEXT, filter); | |||
|
|
|||
| List<Whitelist> aggregation = new ArrayList<>(); | |||
There was a problem hiding this comment.
At this point we should have something like getRuntimeFieldWhitelist for this API since a lot of this config code is the same.
There was a problem hiding this comment.
Agreed, I would prefer to do this as a follow up PR. I even wonder if this should maybe be moved elsewhere. The entirety of including these contexts as part of the module is a bit of an afterthought, though I understand doing them through SPI doesn't make sense here given the dependency hierarchy.
There was a problem hiding this comment.
Well we should cleanup the whitelisting code. Next PR is fine, but if we wanna do a more fundamental change then I'd prefer the wl code cleanup happen first.
modules/lang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/20_scriptfield.yml
Outdated
Show resolved
Hide resolved
modules/lang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/20_scriptfield.yml
Outdated
Show resolved
Hide resolved
|
@stu-elastic Thanks for the review! I believe I've addressed your comment and will commit once CI passes. |
|
@elasticmachine run elasticsearch-ci/part-1 |
This change updates the aggregation script, map script for aggregations, and field scripts to extend DocBasedScript to give them access to the new fields api.
💚 Backport successful
|
This change updates the aggregation script, map script for aggregations, and field scripts to extend DocBasedScript to give them access to the new fields api.