Extract HttpClientStatsTracker #76279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts the functionality in `AbstractHttpServerTransport` that keeps track of the HTTP client stats so that it can be more easily tested in isolation.
DaveCTurner
added
:Distributed Coordination/Network
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
commented
Aug 10, 2021
| // when disabling, immediately clear client stats | ||
| httpChannelStats.clear(); | ||
| } | ||
| return new HttpStats(httpClientStatsTracker.getClientStats(), httpChannels.size(), totalChannelsAccepted.get()); |
There was a problem hiding this comment.
getClientStats also does the prune.
| } | ||
|
|
||
| protected void bindServer() { | ||
| // Bind and start to accept incoming connections. | ||
| InetAddress hostAddresses[]; | ||
| final InetAddress[] hostAddresses; |
There was a problem hiding this comment.
Unrelated, but fixes the only warning left in this file.
| } | ||
| } catch (Exception e) { | ||
| assert false : e; // the listener code above should never throw | ||
| logger.warn("error removing HTTP channel listener", e); |
There was a problem hiding this comment.
Promoted to WARN, as the comment says this should never happen but if it does then it'd be good to hear about it.
original-brownbear
approved these changes
Aug 10, 2021
| */ | ||
| private static int getChannelKey(HttpChannel channel) { | ||
| // always use an identity-based hash code rather than one based on object state | ||
| return System.identityHashCode(channel); |
There was a problem hiding this comment.
Unrelated comment but isn't this broken? I guess it's approximately ok and that might be good enough for the stats, but shouldn't we have a collision safer key here for the stats map?
danhermann
approved these changes
Aug 10, 2021
DaveCTurner
added a commit
that referenced
this pull request
Aug 10, 2021
Extracts the functionality in `AbstractHttpServerTransport` that keeps track of the HTTP client stats so that it can be more easily tested in isolation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the functionality in
AbstractHttpServerTransportthat keepstrack of the HTTP client stats so that it can be more easily tested in
isolation.