Move painless base whitelist into painless jar #76262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base whitelist is shared by all script contexts. However, the text files exist within painless itself, not the limited spi jar which is meant for extension. This commit moves the base definition into painless and reworks context loading in painless to add the base whitelist so that all contexts get it, regardless of whether they have added an explicit whitelist.
rjernst
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
added
auto-backport
|
@elasticmachine retest this please |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 10, 2021
The base whitelist is shared by all script contexts. However, the text files exist within painless itself, not the limited spi jar which is meant for extension. This commit moves the base definition into painless and reworks context loading in painless to add the base whitelist so that all contexts get it, regardless of whether they have added an explicit whitelist.
💚 Backport successful
|
elasticsearchmachine
added a commit
that referenced
this pull request
Aug 10, 2021
The base whitelist is shared by all script contexts. However, the text files exist within painless itself, not the limited spi jar which is meant for extension. This commit moves the base definition into painless and reworks context loading in painless to add the base whitelist so that all contexts get it, regardless of whether they have added an explicit whitelist. Co-authored-by: Ryan Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base whitelist is shared by all script contexts. However, the text
files exist within painless itself, not the limited spi jar which is
meant for extension. This commit moves the base definition into painless
and reworks context loading in painless to add the base whitelist so
that all contexts get it, regardless of whether they have added an
explicit whitelist.