Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PackageUpgradeTests test #76235

Merged

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Aug 9, 2021

This was introduced in #72300
but was not caught by CI there. We will be rethinking how packaging tests
work with security enabled holistically as part of
#75940 but for now this should
solve the issue without needing to mute the test

@jkakavas jkakavas added :Delivery/Build Build or test infrastructure >test-failure Triaged test failures from CI :Security/Security Security issues without another label labels Aug 9, 2021
@jkakavas jkakavas requested a review from pugnascotia August 9, 2021 11:53
@elasticmachine elasticmachine added Team:Delivery Meta label for Delivery team Team:Security Meta label for security team labels Aug 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@mark-vieira
Copy link
Contributor

Thanks for the fix @jkakavas. We'll get upgrade tests added to the CI matrix.

@jkakavas
Copy link
Member Author

jkakavas commented Aug 9, 2021

Thanks for the fix @jkakavas.

No worries, it was me who broke it in the first place :)

@jkakavas jkakavas merged commit 3a36142 into elastic:master Aug 9, 2021
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Aug 9, 2021
Update to elastic#76235
using the correct password this time.
jkakavas added a commit that referenced this pull request Aug 10, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Update to #76235
using the correct password this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure :Security/Security Security issues without another label Team:Delivery Meta label for Delivery team Team:Security Meta label for security team >test-failure Triaged test failures from CI v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants