Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Remove .com from elasticsearch.host setup snippet #76200

Merged
merged 1 commit into from
Aug 10, 2021
Merged

[DOCS] Remove .com from elasticsearch.host setup snippet #76200

merged 1 commit into from
Aug 10, 2021

Conversation

gemaliano
Copy link
Contributor

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added v7.14.1 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 5, 2021
@jrodewig jrodewig added the >docs General docs changes label Aug 5, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Aug 5, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

jrodewig
jrodewig approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @gemaliano.

@jrodewig jrodewig changed the title Update security-basic-setup-https.asciidoc [DOCS] Remove .com from elasticsearch.host setup example Aug 10, 2021
@jrodewig jrodewig changed the title [DOCS] Remove .com from elasticsearch.host setup example [DOCS] Remove .com from elasticsearch.host setup snippet Aug 10, 2021
@jrodewig jrodewig merged commit 8178e87 into 7.14 Aug 10, 2021
@jrodewig jrodewig deleted the gemaliano-patch-1 branch August 10, 2021 17:53
This was referenced Aug 10, 2021
Merged
Merged
Merged
elasticsearchmachine pushed a commit that referenced this pull request Aug 10, 2021
@jrodewig @gemaliano
[DOCS] Remove .com from elasticsearch.host setup snippet (#76200) (…
6b29dc0 
…#76311)

Co-authored-by: Gema Liano Benavides <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Aug 10, 2021
@jrodewig @gemaliano
[DOCS] Remove .com from elasticsearch.host setup snippet (#76200) (…
7a36725 
…#76312)

Co-authored-by: Gema Liano Benavides <[email protected]>
jrodewig added a commit that referenced this pull request Aug 10, 2021
@jrodewig @gemaliano @elasticmachine
[DOCS] Remove .com from elasticsearch.host setup snippet (#76200) (…
2ccad76 
…#76313)

Co-authored-by: Gema Liano Benavides <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@lockewritesdocs lockewritesdocs Awaiting requested review from lockewritesdocs

Assignees
No one assigned
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v7.13.5 v7.14.1 v7.15.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gemaliano @elasticmachine @jrodewig @jakelandis @elasticsearchmachine