-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track cancellable tasks by parent ID #76186
Merged
DaveCTurner
merged 16 commits into
elastic:master
from
DaveCTurner:2021-08-05-track-tasks-by-parent
Aug 9, 2021
+332
−11
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e76da24
Track cancellable tasks by parent ID
DaveCTurner 359aafc
Merge branch 'master' into 2021-08-05-track-tasks-by-parent
DaveCTurner bb7e1c3
No need to look up an un-set parent
DaveCTurner 507aa98
Orphans aren't tracked by id
DaveCTurner 8f65a06
Merge branch 'master' into 2021-08-05-track-tasks-by-parent
DaveCTurner 9aedfa7
Optimize the one-item case
DaveCTurner 6921c0a
Revert "Optimize the one-item case"
DaveCTurner 76ed889
Construct all arrays with copyOf
DaveCTurner b63d6c5
Revert accidental changes
DaveCTurner 03cf0a9
Checkstyle
DaveCTurner 184d410
Add yield hint
DaveCTurner 059c004
Note that items are expected unique
DaveCTurner 9554f12
Add eventually-true assertions
DaveCTurner 16fa401
Weaken assertion, there may always be tasks
DaveCTurner 0d98b3e
Iterable -> Collection
DaveCTurner e0ea7a1
Merge branch 'master' into 2021-08-05-track-tasks-by-parent
DaveCTurner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Note that items are expected unique
commit 059c0041639cbfcf119e3b9baf25376680bd5508
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we extend
TaskAssertions.assertAllCancellableTasksAreCancelled
and perhaps evenESIntegTestCase
to verify that the two maps are in sync after tests have completed (at least that thebyParentId
map only contains items that are also in thebyTaskId
map).We could consider doing it in an assertion too but doing it concurrently while running might be difficult?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I don't think we can express any true invariants very easily; I added an eventually-true assertion in 9554f12.