-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Iron Bank #76087
Fixes for Iron Bank #76087
Conversation
Pinging @elastic/es-delivery (Team:Delivery) |
* Fixes for Iron Bank * Add placeholder for ES tgz checksum
💚 Backport successful
|
Our 7.x and master builds of ES started failing today with the error: from https://kibana-ci.elastic.co/job/elasticsearch+snapshots+build/2864/consoleFull
Do you think this PR might have caused this? |
This reverts commit 5298c52.
It's definitely this PR. I've reverted the commits on |
* Fixes for Iron Bank * Add placeholder for ES tgz checksum
Second attempt after reverting #76087. This PR fixes a number of issues with the Iron Bank Docker context. Most notably it changes the generated `Dockerfile` in the build context to `COPY` the Elasticsearch archive, instead of downloading it, since Iron Bank images have a different process and will never be built on Docker Hub. This requires that the context task be wired to `assemble` instead of the build image task. The latter is only used for testing purposes.
Second attempt after reverting #76087. This PR fixes a number of issues with the Iron Bank Docker context. Most notably it changes the generated `Dockerfile` in the build context to `COPY` the Elasticsearch archive, instead of downloading it, since Iron Bank images have a different process and will never be built on Docker Hub. This requires that the context task be wired to `assemble` instead of the build image task. The latter is only used for testing purposes.
Just keeping the Iron Bank Docker build in sync.