Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Iron Bank #76087

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Conversation

pugnascotia
Copy link
Contributor

Just keeping the Iron Bank Docker build in sync.

@pugnascotia pugnascotia added >non-issue :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v8.0.0 auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v7.15.0 auto-backport-and-merge labels Aug 4, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Aug 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@elasticsearchmachine elasticsearchmachine merged commit 5298c52 into elastic:master Aug 4, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Aug 4, 2021
* Fixes for Iron Bank

* Add placeholder for ES tgz checksum
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

pugnascotia pushed a commit that referenced this pull request Aug 4, 2021
* Fixes for Iron Bank

* Add placeholder for ES tgz checksum
@spalger
Copy link
Contributor

spalger commented Aug 4, 2021

Our 7.x and master builds of ES started failing today with the error:

from https://kibana-ci.elastic.co/job/elasticsearch+snapshots+build/2864/consoleFull

> ./gradlew -Dbuild.docker=true assemble --parallel
...
19:43:28  > Task :distribution:docker:transformUbiDockerContext
19:43:40  
19:43:40  > Task :distribution:docker:buildIronBankDockerImage FAILED
19:43:40  Exec output and error:
19:43:40  | Output for docker:Sending build context to Docker daemon  332.7MB

19:43:40  | Step 1/30 : ARG BASE_REGISTRY=registry1.dso.mil
19:43:40  | Step 2/30 : ARG BASE_IMAGE=ironbank/redhat/ubi/ubi8
19:43:40  | Step 3/30 : ARG BASE_TAG=8.4
19:43:40  | Step 4/30 : FROM ${BASE_REGISTRY}/${BASE_IMAGE}:${BASE_TAG} AS builder
19:43:40  |  ---> 0ced1c7c9b23
19:43:40  | Step 5/30 : COPY tini /bin/tini
19:43:40  |  ---> b8601bce3486
19:43:40  | Step 6/30 : RUN chmod 0555 /bin/tini
19:43:40  |  ---> Running in 9628b5fa5ed4
19:43:40  | Removing intermediate container 9628b5fa5ed4
19:43:40  |  ---> b36e2be4b353
19:43:40  | Step 7/30 : RUN mkdir /usr/share/elasticsearch
19:43:40  |  ---> Running in aae716acd67a
19:43:40  | Removing intermediate container aae716acd67a
19:43:40  |  ---> cf4925c20bec
19:43:40  | Step 8/30 : WORKDIR /usr/share/elasticsearch
19:43:40  |  ---> Running in 3b1690f899c0
19:43:40  | Removing intermediate container 3b1690f899c0
19:43:40  |  ---> 3c524b2e84eb
19:43:40  | Step 9/30 : COPY elasticsearch-7.14.0-linux-x86_64.tar.gz /opt/elasticsearch.tar.gz
19:43:40  | COPY failed: file not found in build context or excluded by .dockerignore: stat elasticsearch-7.14.0-linux-x86_64.tar.gz: file does not exist
19:43:55  
19:43:55  > Task :distribution:docker:buildDockerImage
19:43:59  > Task :distribution:docker:buildUbiDockerImage
19:49:20  
19:49:20  FAILURE: Build failed with an exception.
19:49:20  
19:49:20  * What went wrong:
19:49:20  Execution failed for task ':distribution:docker:buildIronBankDockerImage'.
19:49:20  > A failure occurred while executing org.elasticsearch.gradle.internal.docker.DockerBuildTask$DockerBuildAction
19:49:20     > Process 'command 'docker'' finished with non-zero exit value 1
19:49:20  
19:49:20  * Try:
19:49:20  Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
19:49:20  
19:49:20  * Get more help at https://help.gradle.org
19:49:20  
19:49:20  BUILD FAILED in 18m 17s
19:49:20  1407 actionable tasks: 1407 executed

Do you think this PR might have caused this?

pugnascotia added a commit that referenced this pull request Aug 5, 2021
pugnascotia added a commit that referenced this pull request Aug 5, 2021
@pugnascotia
Copy link
Contributor Author

It's definitely this PR. I've reverted the commits on master and 7.x while I investigate. I think the release-manager was trying to build actual Iron Bank Docker images, which it doesn't need to.

pugnascotia added a commit to pugnascotia/elasticsearch that referenced this pull request Aug 5, 2021
* Fixes for Iron Bank

* Add placeholder for ES tgz checksum
pugnascotia added a commit that referenced this pull request Aug 9, 2021
Second attempt after reverting #76087.

This PR fixes a number of issues with the Iron Bank Docker context. Most
notably it changes the generated `Dockerfile` in the build context to
`COPY` the Elasticsearch archive, instead of downloading it, since Iron
Bank images have a different process and will never be built on Docker Hub.
This requires that the context task be wired to `assemble` instead of the
build image task. The latter is only used for testing purposes.
pugnascotia added a commit that referenced this pull request Aug 9, 2021
Second attempt after reverting #76087.

This PR fixes a number of issues with the Iron Bank Docker context. Most
notably it changes the generated `Dockerfile` in the build context to
`COPY` the Elasticsearch archive, instead of downloading it, since Iron
Bank images have a different process and will never be built on Docker Hub.
This requires that the context task be wired to `assemble` instead of the
build image task. The latter is only used for testing purposes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >non-issue Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants