QL: Make UnaryPlan.replaceChild public and use it where appropriate #76071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luegg
added
>refactoring
:Analytics/SQL
|
Pinging @elastic/es-ql (Team:QL) |
Luegg
force-pushed
the
refactor/publicReplaceChild
branch
from
d20df3d to
34e7c28
Compare
Luegg
force-pushed
the
refactor/publicReplaceChild
branch
from
34e7c28 to
f7a0f90
Compare
mark-vieira
added
auto-backport
costin
approved these changes
Aug 5, 2021
Yes, so was I. Maybe people used slightly other approaches to achieve the same or I just came across it increasingly in the past weeks. And there is also one or the other open PR that uses the pattern as well. |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 5, 2021
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 5, 2021
elasticsearchmachine
added a commit
that referenced
this pull request
Aug 5, 2021
…76071) (#76154) Co-authored-by: Lukas Wegmann <[email protected]>
elasticsearchmachine
added a commit
that referenced
this pull request
Aug 5, 2021
…76071) (#76155) Co-authored-by: Lukas Wegmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
replaceChildrenSameSize(singletonList(...))pattern is used more and more often but can easily be replaced byreplaceChild(...).This PR:
UnaryPlan.replaceChildpublic (and all of its implementations)replaceChildrenSameSize(singletonList(...))withreplaceChild(...)where it can be done in a trivial transformation