Fix null value usage for index.number_of_routing_shards setting. #76069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the same number of routing shards is used for new indices when `index.number_of_routing_shards` is not specified and `null` as value is specified. Without this change if no index.number_of_routing_shards has been specified then logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks and calculates a default based on number of primary shards use that as the true number of routing shards. If a value is specified (including null) then the value the true number of routing shards is determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and in the case of when null is specified then the default value is gathered from the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting. Closes elastic#75139
martijnvg
added
>bug
:Data Management/Indices APIs
|
Pinging @elastic/es-core-features (Team:Core/Features) |
joegallo
reviewed
Aug 4, 2021
server/src/test/java/org/elasticsearch/cluster/metadata/MetadataCreateIndexServiceTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/part-2 |
joegallo
approved these changes
Aug 5, 2021
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 5, 2021
…stic#76069) Ensure that the same number of routing shards is used for new indices when `index.number_of_routing_shards` is not specified and `null` as value is specified. Without this change if no index.number_of_routing_shards has been specified then logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks and calculates a default based on number of primary shards use that as the true number of routing shards. If a value is specified (including null) then the value the true number of routing shards is determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and in the case of when null is specified then the default value is gathered from the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting. Closes elastic#75139
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 5, 2021
…stic#76069) Ensure that the same number of routing shards is used for new indices when `index.number_of_routing_shards` is not specified and `null` as value is specified. Without this change if no index.number_of_routing_shards has been specified then logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks and calculates a default based on number of primary shards use that as the true number of routing shards. If a value is specified (including null) then the value the true number of routing shards is determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and in the case of when null is specified then the default value is gathered from the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting. Closes elastic#75139
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Aug 5, 2021
…stic#76069) Ensure that the same number of routing shards is used for new indices when `index.number_of_routing_shards` is not specified and `null` as value is specified. Without this change if no index.number_of_routing_shards has been specified then logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks and calculates a default based on number of primary shards use that as the true number of routing shards. If a value is specified (including null) then the value the true number of routing shards is determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and in the case of when null is specified then the default value is gathered from the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting. Closes elastic#75139
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Aug 5, 2021
…stic#76069) Ensure that the same number of routing shards is used for new indices when `index.number_of_routing_shards` is not specified and `null` as value is specified. Without this change if no index.number_of_routing_shards has been specified then logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks and calculates a default based on number of primary shards use that as the true number of routing shards. If a value is specified (including null) then the value the true number of routing shards is determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and in the case of when null is specified then the default value is gathered from the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting. Closes elastic#75139
martijnvg
added a commit
that referenced
this pull request
Aug 5, 2021
) Backporting #76069 to 7.x branch. Ensure that the same number of routing shards is used for new indices when `index.number_of_routing_shards` is not specified and `null` as value is specified. Without this change if no index.number_of_routing_shards has been specified then logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks and calculates a default based on number of primary shards use that as the true number of routing shards. If a value is specified (including null) then the value the true number of routing shards is determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and in the case of when null is specified then the default value is gathered from the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting. Closes #75139 Co-authored-by: Martijn van Groningen <[email protected]>
martijnvg
added a commit
that referenced
this pull request
Aug 5, 2021
) Backport #76069 to 7.14 branch. Ensure that the same number of routing shards is used for new indices when `index.number_of_routing_shards` is not specified and `null` as value is specified. Without this change if no index.number_of_routing_shards has been specified then logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks and calculates a default based on number of primary shards use that as the true number of routing shards. If a value is specified (including null) then the value the true number of routing shards is determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and in the case of when null is specified then the default value is gathered from the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting. Closes #75139 Co-authored-by: Martijn van Groningen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the same number of routing shards is used for new indices
when
index.number_of_routing_shardsis not specified andnullas value is specified.Without this change if no index.number_of_routing_shards has been specified then
logic inside the MetadataCreateIndexService#getIndexNumberOfRoutingShards(...) kicks in and
calculates a default based on number of primary shards use that as the true number of routing shards.
If a value is specified (including null) then the value the true number of routing shards is
determined from the IndexMetadata.INDEX_NUMBER_OF_ROUTING_SHARDS_SETTING setting and
in the case of when null is specified then the default value is gathered from
the IndexMetadata.INDEX_NUMBER_OF_SHARDS_SETTING setting.
Closes #75139