Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GeoShapeWithDocValuesFieldTypeTests#testFetchVectorTile #76063

Merged
merged 5 commits into from
Aug 5, 2021
Merged

Fix GeoShapeWithDocValuesFieldTypeTests#testFetchVectorTile #76063

merged 5 commits into from
Aug 5, 2021

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Aug 4, 2021 •
edited
Loading

Ignore invalid geometries the same way we are doing it in ArraySourceValueFetcher. In addition we only simplify (multi)
polygons if they are valid, otherwise the algorithm might fail and produce a stackoverflowerror.

closes #76059

@iverase
Fix GeoShapeWithDocValuesFieldTypeTests#testFetchVectorTile
e1f492a 
ignore invalid geometries the same wat we are doing it in ArraySourceValueFetcher
@iverase iverase added >non-issue :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.15.0 labels Aug 4, 2021
@iverase iverase requested a review from imotov August 4, 2021 08:08
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 4, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

imotov
imotov approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit 2985f7f into elastic:master Aug 5, 2021
@iverase iverase deleted the fixTestFetchVectorTile branch August 5, 2021 06:13
@iverase iverase mentioned this pull request Aug 5, 2021
Merged
iverase added a commit that referenced this pull request Aug 5, 2021
@iverase
Fix GeoShapeWithDocValuesFieldTypeTests#testFetchVectorTile(#76063) (#…
e5f6688 
…76141)

ignore invalid geometries the same way we are doing it in ArraySourceValueFetcher and
only simplify (multi)polygons if they are valid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imotov imotov imotov approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.15.0 v8.0.0-alpha2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] GeoShapeWithDocValuesFieldTypeTests testFetchVectorTile failing
4 participants
@iverase @elasticmachine @imotov @jakelandis