Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove _all for <snapshot> parameter #76030

Closed
wants to merge 1 commit into from

Conversation

lockewritesdocs
Copy link
Contributor

Removes the _all option for the <snapshot> parameter of the get snapshot API. The _all option is supported only for the <repository> parameter in 7.13.

Closes #75997

Removes the `_all` option for the `<snapshot>` parameter of the get snapshot API. The `_all` option is supported only for the `<repository>` parameter in 7.13.

Closes #75997
@lockewritesdocs lockewritesdocs added >bug >docs General docs changes :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.13.4 labels Aug 3, 2021
@lockewritesdocs lockewritesdocs self-assigned this Aug 3, 2021
@elasticmachine elasticmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team labels Aug 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@DaveCTurner
Copy link
Contributor

I think _all has been legitimate for the {snapshot} parameter since forever, it's the {repository} parameter that has to name a single repository in versions <7.14.

Also NB the docs are right in 7.14, it's versions 7.9--7.13 that are wrong.

@lockewritesdocs
Copy link
Contributor Author

lockewritesdocs commented Aug 3, 2021

I think _all has been legitimate for the {snapshot} parameter since forever, it's the {repository} parameter that has to name a single repository in versions <7.14.

I tested on a 7.13.3 cloud instance, and specifying _all for the repository works:
image

However, when specifying _all for the <snapshot> parameter with a repository, the request fails:
image

Also NB the docs are right in 7.14, it's versions 7.9--7.13 that are wrong.
@DaveCTurner, this was supposed to be for 7.13 -- I ended up editing the wrong version. I'll create a new PR for 7.13 after we determine the required fix.

@DaveCTurner
Copy link
Contributor

Confusingly GET _snapshot/{repository} is the get-repository API which has supported multiple repositories (and * and _all) since forever. The issue is about the get-snapshots API: GET _snapshot/{repository}/{snapshot}.

I'm surprised by the response to GET _snapshot/my-snapshots/_all, but that doesn't indicate that _all isn't supported, just that the repository is in a weird state.

@lockewritesdocs
Copy link
Contributor Author

Closing in favor of #76036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. Team:Docs Meta label for docs team v7.13.4 v7.14.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants