-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip node shutdown feature flag to default to true on snapshot builds #75962
Merged
elasticsearchmachine
merged 2 commits into
elastic:master
from
dakrone:shutdown-ff-default-true
Aug 2, 2021
Merged
Flip node shutdown feature flag to default to true on snapshot builds #75962
elasticsearchmachine
merged 2 commits into
elastic:master
from
dakrone:shutdown-ff-default-true
Aug 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously defaulted to false. The setting can still only be set to 'true' on a non-release (snapshot) build of Elasticsearch. Relates to elastic#70338
dakrone
added
v8.0.0
:Core/Infra/Node Lifecycle
Node startup, bootstrapping, and shutdown
v7.15.0
labels
Aug 2, 2021
Pinging @elastic/es-core-infra (Team:Core/Infra) |
22 tasks
gwbrown
approved these changes
Aug 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
dakrone
added
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
labels
Aug 2, 2021
Pinging @elastic/clients-team (Team:Clients) |
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Aug 2, 2021
…elastic#75962) * Flip node shutdown feature flag to default to true on snapshot builds It previously defaulted to false. The setting can still only be set to 'true' on a non-release (snapshot) build of Elasticsearch. Relates to elastic#70338 * Handle case where operator privileges are enabled
💚 Backport successful
|
dakrone
added a commit
that referenced
this pull request
Aug 2, 2021
…builds (#75962) (#75980) Co-authored-by: Lee Hinman <[email protected]> Co-authored-by: Lee Hinman <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Aug 3, 2021
…elastic#75962) * Flip node shutdown feature flag to default to true on snapshot builds It previously defaulted to false. The setting can still only be set to 'true' on a non-release (snapshot) build of Elasticsearch. Relates to elastic#70338 * Handle case where operator privileges are enabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Core/Infra/Node Lifecycle
Node startup, bootstrapping, and shutdown
>non-issue
Team:Clients
Meta label for clients team
Team:Core/Infra
Meta label for core/infra team
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It previously defaulted to false. The setting can still only be set to 'true' on a
non-release (snapshot) build of Elasticsearch.
Relates to #70338