Fix Finalizing Failed Shard Snapshots #75953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We must never write generations extracted out of failed shard snapshot status values to the repository as these can not be trusted in all cases. Instead we must always put a `null` for these into the generations object to write to the repo so that the existing generations are not changed.
original-brownbear
added
>bug
WIP
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine update branch |
…s' into never-finalize-failed-generations
|
Thanks David! |
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Aug 3, 2021
We must never write generations extracted out of failed shard snapshot status values to the repository as these can not be trusted in all cases. Instead we must always put a `null` for these into the generations object to write to the repo so that the existing generations are not changed.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 16, 2021
We must never write generations extracted out of failed shard snapshot status values to the repository as these can not be trusted in all cases. Instead we must always put a `null` for these into the generations object to write to the repo so that the existing generations are not changed.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 16, 2021
We must never write generations extracted out of failed shard snapshot status values to the repository as these can not be trusted in all cases. Instead we must always put a `null` for these into the generations object to write to the repo so that the existing generations are not changed.
original-brownbear
added a commit
that referenced
this pull request
Aug 17, 2021
We must never write generations extracted out of failed shard snapshot status values to the repository as these can not be trusted in all cases. Instead we must always put a `null` for these into the generations object to write to the repo so that the existing generations are not changed.
original-brownbear
added a commit
that referenced
this pull request
Aug 17, 2021
We must never write generations extracted out of failed shard snapshot status values to the repository as these can not be trusted in all cases. Instead we must always put a `null` for these into the generations object to write to the repo so that the existing generations are not changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must never write generations extracted out of failed shard snapshot status values
to the repository as these can not be trusted in all cases. Instead we must always put a
nullfor these into the generations object to write to the repo so that the existing generations are
not changed.
WIP because I'm struggling to find a deterministic test for this. Other than that this fixes the snapshot stress tests yet again.