Log reindex bulk request completion #75935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we log at `DEBUG` when we receive a scroll response and send the bulk request but do not log the completion of the bulk request or the start of the next scroll request. This makes it impossible to tell from the logs how long these things are taking. This commit adds the missing logging.
DaveCTurner
added
>enhancement
v8.0.0
:Distributed Indexing/Reindex
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
martijnvg
approved these changes
Aug 2, 2021
|
I think this message is redundant (unless we care about the scroll ID which I reckon we almost always don't) so I just pushed it down to |
Ok, that is also good with me. |
DaveCTurner
added a commit
that referenced
this pull request
Aug 2, 2021
Today we log at `DEBUG` when we receive a scroll response and send the bulk request but do not log the completion of the bulk request or the start of the next scroll request. This makes it impossible to tell from the logs how long these things are taking. This commit adds the missing logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we log at
DEBUGwhen we receive a scroll response and send thebulk request but do not log the completion of the bulk request or the
start of the next scroll request. This makes it impossible to tell from
the logs how long these things are taking.
This commit adds the missing logging.