Use TestArtifact plugin instead of custom test jar tasks #75931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
:Delivery/Build
breskeby
force-pushed
the
use-internal-test-artifact-plugin
branch
from
6ae3f0d to
bd21695
Compare
breskeby
force-pushed
the
use-internal-test-artifact-plugin
branch
from
bd21695 to
b93993a
Compare
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Aug 2, 2021
mark-vieira
reviewed
Aug 2, 2021
| artifacts { | ||
| testArtifacts testJar | ||
| } | ||
|
|
||
| subprojects { | ||
| // Use tests from the root security qa project in subprojects | ||
| configurations.create('testArtifacts') |
There was a problem hiding this comment.
Shouldn't the plugin create this configuration?
There was a problem hiding this comment.
no. this is the consuming project. the plugin is just for providing the artifact. for consuming we only added the testArtifact convenience method see
Lines 57 to 74 in fd6d966
| @@ -24,7 +15,9 @@ subprojects { | |||
|
|
|||
| dependencies { | |||
| testImplementation project(":x-pack:plugin:core") | |||
| testArtifacts project(path: mainProject.path, configuration: 'testArtifacts') | |||
| testArtifacts(testArtifact(project(mainProject.path))) { | |||
| transitive = false | |||
There was a problem hiding this comment.
Why do we have to disable transitive dependencies here? Couldn't we do this on the configuration?
There was a problem hiding this comment.
true. changed to be done on the configuration
|
@elasticmachine update branch |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Aug 5, 2021
Make use of test artifact plugin and avoid using custom test jars created manually. Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 5, 2021
…6189) Make use of test artifact plugin and avoid using custom test jars created manually. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifies build logic and avoids custom creation of test artifacts