Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix serialization of datafeed running state for relocated datafeed #75929

Merged

Conversation

droberts195
Copy link
Contributor

The datafeed running state was set to null for a datafeed that
had recently moved to a different node. This resulted in an
exception while serializing between nodes (but would also
cause incomplete information in the datafeed stats response).

This change makes the datafeed running state return the best
information available in this case:

  • real_time_configured will return the correct value
  • real_time_running will return false, which is reasonable
    since the datafeed has yet got started on the new node

Backport of #75923

The datafeed running state was set to null for a datafeed that
had recently moved to a different node. This resulted in an
exception while serializing between nodes (but would also
cause incomplete information in the datafeed stats response).

This change makes the datafeed running state return the best
information available in this case:

- real_time_configured will return the correct value
- real_time_running will return false, which is reasonable
  since the datafeed has yet got started on the new node

Backport of elastic#75923
@droberts195 droberts195 added backport auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) v7.15.0 labels Aug 2, 2021
@elasticsearchmachine elasticsearchmachine merged commit 7fb5ba5 into elastic:7.x Aug 2, 2021
@droberts195 droberts195 deleted the fix_datafeed_state_npe_7x branch August 2, 2021 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport v7.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants