Include extra snapshot details in logs/APIs #75917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today we do not expose the shard generations in the cluster state API, nor do we indicate which snapshots are being deleted in the cluster state update description; these data would have been useful in a recent debugging session. This commit adds these extra details, and also expands some comments on `ClusterState` describing how it's used as an `XContentFragment`.
DaveCTurner
added
>enhancement
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
@elasticmachine please run elasticsearch-ci/rest-compatibility |
|
Thanks Armin :) |
DaveCTurner
added a commit
that referenced
this pull request
Aug 3, 2021
Today we do not expose the shard generations in the cluster state API, nor do we indicate which snapshots are being deleted in the cluster state update description; these data would have been useful in a recent debugging session. This commit adds these extra details, and also expands some comments on `ClusterState` describing how it's used as an `XContentFragment`.
DaveCTurner
added a commit
that referenced
this pull request
Aug 3, 2021
In #75917 we introduced an assertion that relied on the order of the shards in the JSON representation of a `SnapshotsInProgress` but in fact we might end up with the shards in either order. This commit weakens the assertion to fix the test.
DaveCTurner
added a commit
that referenced
this pull request
Aug 3, 2021
In #75917 we introduced an assertion that relied on the order of the shards in the JSON representation of a `SnapshotsInProgress` but in fact we might end up with the shards in either order. This commit weakens the assertion to fix the test.
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Aug 3, 2021
Today we do not expose the shard generations in the cluster state API, nor do we indicate which snapshots are being deleted in the cluster state update description; these data would have been useful in a recent debugging session. This commit adds these extra details, and also expands some comments on `ClusterState` describing how it's used as an `XContentFragment`.
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Aug 3, 2021
In elastic#75917 we introduced an assertion that relied on the order of the shards in the JSON representation of a `SnapshotsInProgress` but in fact we might end up with the shards in either order. This commit weakens the assertion to fix the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we do not expose the shard generations in the cluster state API,
nor do we indicate which snapshots are being deleted in the cluster
state update description; these data would have been useful in a recent
debugging session. This commit adds these extra details, and also
expands some comments on
ClusterStatedescribing how it's used as anXContentFragment.