Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for _meta field to ingest pipelines #75905

Merged
merged 16 commits into from
Aug 11, 2021

Conversation

masseyke
Copy link
Member

Adds a _meta field to ingest pipelines for custom user metadata

@masseyke masseyke linked an issue Jul 30, 2021 that may be closed by this pull request
@masseyke masseyke added v7.15.0 Team:Data Management Meta label for data/management team labels Jul 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@masseyke masseyke marked this pull request as draft July 30, 2021 21:21
@masseyke
Copy link
Member Author

masseyke commented Aug 5, 2021

@elasticmachine update branch

@masseyke masseyke marked this pull request as ready for review August 5, 2021 20:12
@jakelandis jakelandis requested a review from danhermann August 9, 2021 20:25
Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masseyke, thanks for working on this. I've added one question below and requested that @jrodewig look over the doc changes.

@jrodewig jrodewig self-requested a review August 9, 2021 20:52
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a typo in the header. The other feedback is non-blocking nits.

Thanks @masseyke!

docs/reference/ingest/apis/put-pipeline.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/apis/put-pipeline.asciidoc Outdated Show resolved Hide resolved
docs/reference/ingest/apis/put-pipeline.asciidoc Outdated Show resolved Hide resolved
@masseyke
Copy link
Member Author

@elasticmachine update branch

@danhermann
Copy link
Contributor

Thanks, @masseyke. LGTM once CI is happy (looks like checkstyle is flagging some unused imports in PipelineConfiguration right now)

@masseyke
Copy link
Member Author

@elasticmachine run elasticsearch-ci/precommit

@masseyke masseyke merged commit 498684a into elastic:master Aug 11, 2021
@masseyke masseyke deleted the feature/add_meta_to_ingest_pipelines branch August 11, 2021 13:30
masseyke added a commit to masseyke/elasticsearch that referenced this pull request Aug 11, 2021
We are adding a _meta field to many of our REST APIs so that users can attach whatever metadata they
want. The data in this field will not be used by Elasticsearch. This commit add the _meta field to ingest
pipelines.
@masseyke masseyke added v7.15.0 :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Deployment Management Meta label for Management Experience - Deployment Management team labels Aug 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/kibana-stack-management (Team:Stack Management)

masseyke added a commit that referenced this pull request Aug 11, 2021
We are adding a _meta field to many of our REST APIs so that users can attach whatever metadata they
want. The data in this field will not be used by Elasticsearch. This commit add the _meta field to ingest
pipelines.
Relates to #75799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team Team:Deployment Management Meta label for Management Experience - Deployment Management team v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for _meta field to ingest pipelines
7 participants