Make sure to include class name in Query hash codes #75871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some Query subclasses, we forgot to include the class name when computing hashCode. This could increase the chance of collision between query hash codes. Hash code collisions shouldn't affect correctness, but could change query caching behavior since UsageTrackingQueryCachingPolicy tracks query frequency based on hash codes. The PR also simplifies some 'equals' methods to use the helper method sameClassAs.
jtibshirani
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
I noticed this while investigating #75848. I don't have evidence it was actually causing the surprising caching behavior, but seems worth fixing on its own. |
|
Thanks for the review ! |
jtibshirani
added a commit
that referenced
this pull request
Aug 3, 2021
In some Query subclasses, we forgot to include the class name when computing hashCode. This could increase the chance of collision between query hash codes. Hash code collisions shouldn't affect correctness, but could change query caching behavior since UsageTrackingQueryCachingPolicy tracks query frequency based on hash codes. The PR also simplifies some 'equals' methods to use the helper method sameClassAs.
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Aug 3, 2021
In some Query subclasses, we forgot to include the class name when computing hashCode. This could increase the chance of collision between query hash codes. Hash code collisions shouldn't affect correctness, but could change query caching behavior since UsageTrackingQueryCachingPolicy tracks query frequency based on hash codes. The PR also simplifies some 'equals' methods to use the helper method sameClassAs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some Query subclasses, we forgot to include the class name when computing
hashCode. This could increase the chance of collision between query hash codes.
Hash code collisions shouldn't affect correctness, but could change query
caching behavior since UsageTrackingQueryCachingPolicy tracks query frequency
based on hash codes.
The PR also simplifies some 'equals' methods to use the helper method
sameClassAs.