Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Include index param in geo_point docs #75798

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Conversation

a-k-g
Copy link
Contributor

@a-k-g a-k-g commented Jul 28, 2021

Based on local testing in docker it seems that geo_point type fields actually support the index param. Docs don't seem to mention that currently.

Tested by creating an index with the following mapping on 6.8.16:

{
    "mappings": {
        "_doc": {
            "properties": {
                "fieldValue": {
                    "type": "geo_point",
                    "index": "false"
                }
            }
        }
    }
}

Also tested on 7.13.4 without nesting inside the _doc type.

Would be nice to port this back to previous versions too.

@elasticsearchmachine elasticsearchmachine added v8.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 28, 2021
@mark-vieira mark-vieira added the >docs General docs changes label Jul 29, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@jrodewig jrodewig added the :Analytics/Geo Indexing, search aggregations of geo points and shapes label Aug 3, 2021
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Aug 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@jrodewig
Copy link
Contributor

jrodewig commented Aug 3, 2021

@elasticmachine ok to test

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @a-k-g!

@a-k-g
Copy link
Contributor Author

a-k-g commented Aug 3, 2021

Great, thanks! Is there any action required to also backport this?

@jrodewig
Copy link
Contributor

jrodewig commented Aug 3, 2021

Is there any action required to also backport this?

I'll merge and backport this once our CI tests pass. Per our backporting policy, I'll backport to our currently maintained versions: 7.x, 7.14, 7.13, and 6.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v6.8.18 v7.13.5 v7.14.1 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants