-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] fix count ks test aggregator test consistency #75793
Merged
benwtrent
merged 1 commit into
elastic:master
from
benwtrent:tests/ml-ks-test-consistency
Jul 29, 2021
Merged
[ML] fix count ks test aggregator test consistency #75793
benwtrent
merged 1 commit into
elastic:master
from
benwtrent:tests/ml-ks-test-consistency
Jul 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testKsTest_LowerTailedValues is failing due to distribution issues. The random variables in the sparse case are too uniform and causing two-sided alternative tests to not be consistent. closes elastic#74909
benwtrent
added
>test
Issues or PRs that are addressing/adding tests
:ml
Machine learning
v8.0.0
auto-backport
Automatically create backport pull requests when merged
v7.14.1
v7.15.0
labels
Jul 28, 2021
Pinging @elastic/ml-core (Team:ML) |
przemekwitek
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 29, 2021
testKsTest_LowerTailedValues is failing due to distribution issues. The random variables in the sparse case are too uniform and causing two-sided alternative tests to not be consistent. closes elastic#74909
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 29, 2021
testKsTest_LowerTailedValues is failing due to distribution issues. The random variables in the sparse case are too uniform and causing two-sided alternative tests to not be consistent. closes elastic#74909
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 29, 2021
testKsTest_LowerTailedValues is failing due to distribution issues. The random variables in the sparse case are too uniform and causing two-sided alternative tests to not be consistent. closes #74909 Co-authored-by: Benjamin Trent <[email protected]>
elasticsearchmachine
added a commit
that referenced
this pull request
Jul 29, 2021
testKsTest_LowerTailedValues is failing due to distribution issues. The random variables in the sparse case are too uniform and causing two-sided alternative tests to not be consistent. closes #74909 Co-authored-by: Benjamin Trent <[email protected]>
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
testKsTest_LowerTailedValues is failing due to distribution issues. The random variables in the sparse case are too uniform and causing two-sided alternative tests to not be consistent. closes elastic#74909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:ml
Machine learning
Team:ML
Meta label for the ML team
>test
Issues or PRs that are addressing/adding tests
v7.14.0
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testKsTest_LowerTailedValues is failing due to distribution
issues. The random variables in the sparse case are too
uniform and causing two-sided alternative
tests to not be consistent.
closes #74909