Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: ILM document behaviour for changing lifecycle setting #75790

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

andreidan
Copy link
Contributor

Closes #70151

@andreidan andreidan added >docs General docs changes :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.15.0 labels Jul 28, 2021
@andreidan andreidan requested a review from jrodewig July 28, 2021 14:48
@elasticmachine elasticmachine added Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team labels Jul 28, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andreidan. The changes look good but may be redundant. WDYT?

Comment on lines 41 to 44
The name of the policy to use to manage the index. As the current executing phase
definition is cached in the index metadata, changing the setting to a different policy
will not affect the currently executing phase, but the next phase will be read from
the newly configured policy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to say the same thing as https://www.elastic.co/guide/en/elasticsearch/reference/master/update-lifecycle-policy.html#ilm-apply-new-policy. I wonder if we should just add an xref to there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrodewig great point! I missed that we document this already. An xref sounds great

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I pushed 28f7fce to add an xref.

Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @andreidan.

@andreidan andreidan added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Jul 29, 2021
@andreidan andreidan merged commit 57b5a1b into elastic:master Jul 29, 2021
elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Jul 29, 2021
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

elasticsearchmachine added a commit that referenced this pull request Jul 29, 2021
…75827)

Add xref

Co-authored-by: James Rodewig <[email protected]>

Co-authored-by: Andrei Dan <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/ILM+SLM Index and Snapshot lifecycle management >docs General docs changes Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the ILM policy for a managed index is non-deterministic
5 participants