-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid running all EQL BWC tasks when running check #75743
Conversation
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI.
Pinging @elastic/es-delivery (Team:Delivery) |
You can see in this build scan we are running all index compatible version tests when running the |
@astefan it looks like #68802 was never reviewed before being merged. As a point of process going forward please add someone from the delivery team to review any PRs that include substantial build-related changes such as adding new BWC test suites. It's super easy to shoot yourself in the foot with this sort of stuff 😉 |
@mark-vieira that PR is made of three other PRs and all of them were approved, as mentioned in the PR description. |
Regarding the usage of @mark-vieira When running CI jobs for new PRs, is |
Yes, but only against snapshot versions. We don't run BWC tests against every compatible released version because it would prohibitively costly to so. |
As you can see from the build scan for this pull request, we run the EQL mixed cluster tests, but only against 7.15. https://gradle-enterprise.elastic.co/s/oagspdqk7fkye/tests?search=eql We then have a separate periodic CI job that runs the full set of versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI.
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI.
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI.
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI. Co-authored-by: Mark Vieira <[email protected]>
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI. Co-authored-by: Mark Vieira <[email protected]>
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI. Co-authored-by: Mark Vieira <[email protected]>
The bwc-test plugin automatically wires up BWC tasks to the appropriate lifecycle tasks for us. There's no need to do this explicitly. Running 'check' should only run BWC tests against unreleased versions as-per convention. Released version tests are run via periodic jobs in CI.
The bwc-test plugin automatically wires up BWC tasks to the appropriate
lifecycle tasks for us. There's no need to do this explicitly. Running
'check' should only run BWC tests against unreleased versions as-per
convention. Released version tests are run via periodic jobs in CI.