Use reader wrapper in ReadOnlyEngine #75724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywelsch
added
>bug
:Distributed Indexing/Engine
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywelsch
commented
Jul 27, 2021
| - match: { nodes.$node_id.shared_cache.bytes_written: "0b" } | ||
| - match: { nodes.$node_id.shared_cache.bytes_written_in_bytes: 0 } | ||
| - match: { nodes.$node_id.shared_cache.evictions: 0 } | ||
| - gte: { nodes.$node_id.shared_cache.reads: 0 } |
There was a problem hiding this comment.
This is an interesting side-effect here because we now actually start using the cache.
ywelsch
added a commit
that referenced
this pull request
Jul 27, 2021
Ensures the reader wrapper is always used in ReadOnlyEngine.
ywelsch
added a commit
that referenced
this pull request
Jul 27, 2021
Ensures the reader wrapper is always used in ReadOnlyEngine.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
Ensures the reader wrapper is always used in ReadOnlyEngine.
|
Thanks for fixing this Yannick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the reader wrapper is always used in ReadOnlyEngine. To test this PR, I enabled security on the searchable snapshot REST tests.