Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings in :server - part 1 #75708

Merged
merged 15 commits into from
Jul 27, 2021

Conversation

pugnascotia
Copy link
Contributor

Part of #40366. Fix a number of javac issues when linting is enforced in server/. Due to the number of issues that this surfaces, the fixes will be spread of multiple PRs.

@pugnascotia pugnascotia requested a review from mark-vieira July 26, 2021 20:59
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jul 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pugnascotia
Copy link
Contributor Author

@elasticmachine update branch

@pugnascotia pugnascotia merged commit 944b3f3 into elastic:master Jul 27, 2021
@pugnascotia pugnascotia deleted the 40366-lint-warnings-server-pt1 branch July 27, 2021 18:40
pugnascotia added a commit that referenced this pull request Jul 27, 2021
Part of #40366. Fix a number of javac issues when linting is enforced in `server/`.
@pugnascotia
Copy link
Contributor Author

Backported to 7.x in 84346d9

ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
Part of elastic#40366. Fix a number of javac issues when linting is enforced in `server/`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >refactoring Team:Delivery Meta label for Delivery team v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants