-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILM ClusterStateWaitThresholdBreachTests cycles due to shrunk-shards-allocated
#75695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-allocated` ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step.
andreidan
added
>test
Issues or PRs that are addressing/adding tests
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
v8.0.0
v7.15.0
labels
Jul 26, 2021
elasticmachine
added
the
Team:Data Management
Meta label for data/management team
label
Jul 26, 2021
Pinging @elastic/es-core-features (Team:Core/Features) |
dakrone
approved these changes
Jul 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this Andrei
andreidan
added
the
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
label
Jul 27, 2021
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Jul 27, 2021
…-allocated` (elastic#75695) ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step. (cherry picked from commit 3b2973d) Signed-off-by: Andrei Dan <[email protected]> # Conflicts: # x-pack/plugin/ilm/src/internalClusterTest/java/org/elasticsearch/xpack/ilm/ClusterStateWaitThresholdBreachTests.java
andreidan
added a commit
that referenced
this pull request
Jul 27, 2021
…-allocated` (#75695) (#75729) ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step. (cherry picked from commit 3b2973d) Signed-off-by: Andrei Dan <[email protected]> # Conflicts: # x-pack/plugin/ilm/src/internalClusterTest/java/org/elasticsearch/xpack/ilm/ClusterStateWaitThresholdBreachTests.java
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
…-allocated` (elastic#75695) ClusterStateWaitThresholdBreachTests is meant to simulate a shrink action failure that lasts past the threshold we configured such that ILM rewinds, deletes an attempted shrunk index and retries (successfully the 2nd time). We used to simulated this failure by configuring a shrink action with a number of shards higher than the index number of shards. We're now adding a step that'll validate against this misconfiguration so we needed a new way to integration test this shrink action cycle. This makes the test use a high number of replicas configuration for the managed index, blocking it in the `shrunk-shards-allocated` step, instead of the previous failure in the `shrink` step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
:Data Management/ILM+SLM
Index and Snapshot lifecycle management
Team:Data Management
Meta label for data/management team
>test
Issues or PRs that are addressing/adding tests
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClusterStateWaitThresholdBreachTests is meant to simulate a shrink
action failure that lasts past the threshold we configured such that ILM
rewinds, deletes an attempted shrunk index and retries (successfully the
2nd time).
We used to simulated this failure by configuring a shrink action with a
number of shards higher than the index number of shards. We're now
adding a step that'll validate against this misconfiguration so we
needed a new way to integration test this shrink action cycle.
This makes the test use a high number of replicas configuration for the
managed index, blocking it in the
shrunk-shards-allocated
step,instead of the previous failure in the
shrink
step.Relates to #74219