-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support password_hash for Change Password API #75500
Conversation
This change adds support for a password_hash field in the request body of the Change Password API. Clients can use this to pre-hash the password when making a change password request.
Pinging @elastic/es-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can we add a test to
x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/change_password/10_basic.yml
as well?
I think it's worth having this in the client test suite.
...ain/java/org/elasticsearch/xpack/core/security/action/user/ChangePasswordRequestBuilder.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Vernum <[email protected]>
…security/action/user/ChangePasswordRequestBuilder.java Co-authored-by: Tim Vernum <[email protected]>
part-2-fips failed because of a flaky test: #66495 |
@elasticmachine run elasticsearch-ci/part-2-fips |
x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/change_password/10_basic.yml
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tvernum Do you want to do another round or are you ok to have this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sorry, I didn't realise this was waiting on me.
💚 Backport successful
|
This change adds support for a password_hash field in the request body of the Change Password API. Clients can use this to pre-hash the password when making a change password request.
This change adds support for a password_hash field in the request
body of the Change Password API. Clients can use this to pre-hash
the password when making a change password request.
HLRC support will be added in a follow-up