Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support password_hash for Change Password API #75500

Merged
merged 9 commits into from
Aug 10, 2021

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Jul 19, 2021

This change adds support for a password_hash field in the request
body of the Change Password API. Clients can use this to pre-hash
the password when making a change password request.

HLRC support will be added in a follow-up

This change adds support for a password_hash field in the request
body of the Change Password API. Clients can use this to pre-hash
the password when making a change password request.
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Jul 19, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can we add a test to
x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/change_password/10_basic.yml
as well?

I think it's worth having this in the client test suite.

jkakavas and others added 2 commits July 20, 2021 08:36
…security/action/user/ChangePasswordRequestBuilder.java

Co-authored-by: Tim Vernum <[email protected]>
@jkakavas jkakavas requested a review from BigPandaToo July 20, 2021 06:50
@jkakavas jkakavas removed the :Security/TLS SSL/TLS, Certificates label Jul 20, 2021
@elasticmachine elasticmachine removed the Team:Security Meta label for security team label Jul 20, 2021
@jkakavas jkakavas added the :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) label Jul 20, 2021
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Jul 20, 2021
@jkakavas
Copy link
Member Author

part-2-fips failed because of a flaky test: #66495

@jkakavas
Copy link
Member Author

@elasticmachine run elasticsearch-ci/part-2-fips

Copy link
Contributor

@BigPandaToo BigPandaToo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkakavas jkakavas requested a review from tvernum August 3, 2021 14:45
@jkakavas
Copy link
Member Author

@tvernum Do you want to do another round or are you ok to have this merged?

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Sorry, I didn't realise this was waiting on me.

@jkakavas jkakavas merged commit 061552f into elastic:master Aug 10, 2021
@jkakavas jkakavas added the auto-backport Automatically create backport pull requests when merged label Aug 10, 2021
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.x

elasticsearchmachine pushed a commit to elasticsearchmachine/elasticsearch that referenced this pull request Aug 10, 2021
This change adds support for a password_hash field in the request
body of the Change Password API. Clients can use this to pre-hash
the password when making a change password request.
jkakavas pushed a commit that referenced this pull request Aug 10, 2021
This change adds support for a password_hash field in the request
body of the Change Password API. Clients can use this to pre-hash
the password when making a change password request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >enhancement :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants