[Transform][Rollup] remove unnecessary list indirection #75459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
hendrikmuhs
added
the
:StorageEngine/Rollup
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
|
@elasticmachine update branch |
benwtrent
reviewed
Jul 20, 2021
...ugin/transform/src/main/java/org/elasticsearch/xpack/transform/transforms/latest/Latest.java
Outdated
Show resolved
Hide resolved
nik9000
reviewed
Jul 21, 2021
csoulios
approved these changes
Jul 21, 2021
...ugin/core/src/test/java/org/elasticsearch/xpack/core/indexing/AsyncTwoPhaseIndexerTests.java
Outdated
Show resolved
Hide resolved
przemekwitek
approved these changes
Jul 22, 2021
...m/src/test/java/org/elasticsearch/xpack/transform/transforms/TransformIndexerStateTests.java
Outdated
Show resolved
Hide resolved
...nsform/src/test/java/org/elasticsearch/xpack/transform/transforms/TransformIndexerTests.java
Outdated
Show resolved
Hide resolved
hendrikmuhs
force-pushed
the
stream-indexrequests
branch
from
3484f66 to
0cb6c0a
Compare
benwtrent
approved these changes
Jul 28, 2021
hendrikmuhs
added
the
auto-backport
💔 Backport failed
To backport manually run: |
hendrikmuhs
pushed a commit
that referenced
this pull request
Jul 29, 2021
#75829) Remove an unnecessary indirection and refactor progress tracking. Both rollup and transform process documents as stream, however in the AsyncTwoPhaseIndexer takes a List of index requests. This change removes the unnecessary temporary container and makes upcoming transform enhancements easier.
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
Jul 30, 2021
Remove an unnecessary indirection and refactor progress tracking. Both rollup and transform process documents as stream, however in the AsyncTwoPhaseIndexer takes a List of index requests. This change removes the unnecessary temporary container and makes upcoming transform enhancements easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove an unnecessary indirection and refactor progress tracking. Both rollup and transform process documents as stream, however in the
AsyncTwoPhaseIndexertakes aListof index requests. This change removes the unnecessary temporary container. This simplification makes upcoming transform enhancements easier.Main changes are in 15afd31
The 2nd commit only applies spotless formatting to files belonging to the transform codebase.