Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use contains relation for geo_point intersection over geo_point field #75272

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Jul 13, 2021

For point queries and intersects, lucene does not match points that are encoded to Integer.MAX_VALUE due to the use of predicates. Use contains instead that returns the expected results.

closes #75103

@iverase iverase added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes v8.0.0 v7.15.0 labels Jul 13, 2021
@iverase iverase requested a review from imotov July 13, 2021 07:29
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@iverase
Copy link
Contributor Author

iverase commented Jul 13, 2021

part-1 failed because of #75221, unrelated flaky test

@elasticmachine run elasticsearch-ci/part-1

Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit a537258 into elastic:master Jul 14, 2021
@iverase iverase deleted the pointIntersectsPoint branch July 14, 2021 06:35
iverase added a commit to iverase/elasticsearch that referenced this pull request Jul 14, 2021
…elastic#75272)

 Lucene does not match points that are encoded to Integer.MAX_VALUE for intersects.
iverase added a commit that referenced this pull request Jul 14, 2021
…#75272) (#75321)

Lucene does not match points that are encoded to Integer.MAX_VALUE for intersects.
masseyke pushed a commit to masseyke/elasticsearch that referenced this pull request Jul 16, 2021
…elastic#75272)

 Lucene does not match points that are encoded to Integer.MAX_VALUE for intersects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] GeoPointShapeQueryTests testFieldAlias failing
4 participants