Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for shard stats to data tier telemetry #75185

Merged

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jul 9, 2021

This adds a null check, as getShardStats(index) may return null.

This adds a null check, as `getShardStats(index)` may return null.
@dakrone dakrone added >bug :Data Management/Indices APIs APIs to create and manage indices and templates v8.0.0 v7.14.1 v7.15.0 labels Jul 9, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jul 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@danhermann danhermann self-requested a review July 15, 2021 15:41
@jbaiera jbaiera self-requested a review July 15, 2021 15:42
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Question for myself though: in which cases might the shard stats not be present?

@dakrone
Copy link
Member Author

dakrone commented Jul 15, 2021

@elasticmachine update branch

@dakrone
Copy link
Member Author

dakrone commented Jul 15, 2021

in which cases might the shard stats not be present?

Honestly I am not quite sure yet (which is why I did not originally add a null check). I will try to investigate to see why.

@dakrone dakrone added auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Jul 15, 2021
@elasticsearchmachine elasticsearchmachine merged commit 381c4ef into elastic:master Jul 15, 2021
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
7.14 Commit could not be cherrypicked due to conflicts
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
backport --pr 75185

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 15, 2021
This adds a null check, as `getShardStats(index)` may return null.

Co-authored-by: Elastic Machine <[email protected]>
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 15, 2021
This adds a null check, as `getShardStats(index)` may return null.

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2021
This adds a null check, as `getShardStats(index)` may return null.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2021
This adds a null check, as `getShardStats(index)` may return null.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
masseyke pushed a commit to masseyke/elasticsearch that referenced this pull request Jul 16, 2021
This adds a null check, as `getShardStats(index)` may return null.

Co-authored-by: Elastic Machine <[email protected]>
ywangd pushed a commit to ywangd/elasticsearch that referenced this pull request Jul 30, 2021
This adds a null check, as `getShardStats(index)` may return null.

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >bug :Data Management/Indices APIs APIs to create and manage indices and templates Team:Data Management Meta label for data/management team v7.14.0 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants