-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null check for shard stats to data tier telemetry #75185
Add null check for shard stats to data tier telemetry #75185
Conversation
This adds a null check, as `getShardStats(index)` may return null.
Pinging @elastic/es-core-features (Team:Core/Features) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Question for myself though: in which cases might the shard stats not be present?
@elasticmachine update branch |
Honestly I am not quite sure yet (which is why I did not originally add a null check). I will try to investigate to see why. |
💔 Backport failed
To backport manually run: |
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <[email protected]>
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <[email protected]>
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <[email protected]>
This adds a null check, as `getShardStats(index)` may return null. Co-authored-by: Elastic Machine <[email protected]>
This adds a null check, as
getShardStats(index)
may return null.