Fix _terms_enum default indices options #75172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default indices options of the new terms enum API to be consistent with _search. This change also fixes the shards statistics in the response when ccs is involved. Closes elastic#75155
jimczi
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
markharwood
approved these changes
Jul 9, 2021
|
|
||
| /** | ||
| * A request to gather terms for a given field matching a string prefix | ||
| */ | ||
| public class TermsEnumRequest extends BroadcastRequest<TermsEnumRequest> implements ToXContentObject { | ||
|
|
||
| public static final IndicesOptions DEFAULT_INDICES_OPTIONS = SearchRequest.DEFAULT_INDICES_OPTIONS; |
There was a problem hiding this comment.
Safe to assume terms_enum options will always be aligned with that of search?
There was a problem hiding this comment.
That's the intent of the PR, yes.
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jul 9, 2021
This commit changes the default indices options of the new terms enum API to be consistent with _search. This change also fixes the shards statistics in the response when ccs is involved. Closes elastic#75155
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jul 9, 2021
This commit changes the default indices options of the new terms enum API to be consistent with _search. This change also fixes the shards statistics in the response when ccs is involved. Closes elastic#75155
This was referenced Jul 9, 2021
jimczi
added a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default indices options of the new terms enum API
to be consistent with _search.
This change also fixes the shards statistics in the response when ccs is involved.
Closes #75155