Permit more temp files in data path #74921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a node starts up it creates, then immediately deletes, files called `.es_temp_file.tmp` and `.es_temp_file.final`. If the node is killed at exactly the wrong moment then we may leave one of these files on disk. When upgrading from 7.x to 8.0 we reorganise the contents of the data path, but bail out if we encounter anything unexpected to avoid causing damage in unexpected situations. However we don't consider the temporary files mentioned above as expected, so their existence will cause an upgrade to fail. This commit adjusts the logic to permit these files to exist during the ugprade. Closes elastic#74908
DaveCTurner
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 6, 2021
This reverts commit 2dc796a. The revert was mostly clean, but it required adjusting NodeEnvironment.upgradeLegacyNodeFolders to retain elastic#74921. relates elastic#78525 relates elastic#71205
rjernst
added a commit
that referenced
this pull request
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a node starts up it creates, then immediately deletes, files called
.es_temp_file.tmpand.es_temp_file.final. If the node is killed atexactly the wrong moment then we may leave one of these files on disk.
When upgrading from 7.x to 8.0 we reorganise the contents of the data
path, but bail out if we encounter anything unexpected to avoid causing
damage in unexpected situations. However we don't consider the temporary
files mentioned above as expected, so their existence will cause an
upgrade to fail.
This commit adjusts the logic to permit these files to exist during the
ugprade.
Closes #74908