Alias field does not work with geo_shape query #74895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>bug
:Analytics/Geo
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
imotov
approved these changes
Jul 7, 2021
| @@ -160,7 +160,7 @@ public Query buildShapeQuery(SearchExecutionContext context, MappedFieldType fie | |||
| "Field [" + fieldName + "] is of unsupported type [" + fieldType.typeName() + "] for [" + NAME + "] query"); | |||
| } | |||
| final GeoShapeQueryable ft = (GeoShapeQueryable) fieldType; | |||
| return new ConstantScoreQuery(ft.geoShapeQuery(shape, fieldName, strategy, relation, context)); | |||
| return new ConstantScoreQuery(ft.geoShapeQuery(shape, fieldType.name(), strategy, relation, context)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an alias field on a geo_shape query, the final field name is not resolve properly. This PR fixes it by using the field type name when calling
geoShapeQuery. Note that this still works if the geo_shape field is using legacy parameters.In addition, this PR is refactoring further the GeoShape query Test in order to separate the test that goes to the legacy implementation.