Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.14] Improve circular reference detection in grok processor (#74581) #74829

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

danhermann
Copy link
Contributor

Certain combinations of patterns could result in circular references that were not properly detected. This PR resolves that.

Backport of #74581

@danhermann danhermann added >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP backport v7.14.1 labels Jul 1, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jul 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@danhermann
Copy link
Contributor Author

@elasticmachine test this please

@danhermann
Copy link
Contributor Author

@elasticmachine update branch

@danhermann
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

@danhermann
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/part-2

@droberts195
Copy link
Contributor

The test that's repeatedly failing in elasticsearch-ci/part-2 is the one that this change causes to fail.

It might be simplest just to incorporate the fix into this PR:

git cherry-pick a0d26954bd93b46261d36f194dcbfb7635b40dde

droberts195 and others added 2 commits July 1, 2021 09:21
@danhermann
Copy link
Contributor Author

All tests passed. Some test result updates on the PR were delayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport >bug :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants