-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Away Small Resumable Uploads in GCS Repository #74813
Merged
original-brownbear
merged 1 commit into
elastic:master
from
original-brownbear:optimize-away-resumable-writes-gcs
Jul 1, 2021
Merged
Optimize Away Small Resumable Uploads in GCS Repository #74813
original-brownbear
merged 1 commit into
elastic:master
from
original-brownbear:optimize-away-resumable-writes-gcs
Jul 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to ChunkedOutputStream we can optimize away small resumable uploads to speed up small meta writes (and improve stability with JDK-8 in 7.x).
Pinging @elastic/es-distributed (Team:Distributed) |
tlrx
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1 on 7.14
Thanks Tanguy! |
LTGM 2. Too quick for me this time :D |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 14, 2021
Similar to ChunkedOutputStream we can optimize away small resumable uploads to speed up small meta writes (and improve stability with JDK-8 in 7.x).
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 14, 2021
Similar to ChunkedOutputStream we can optimize away small resumable uploads to speed up small meta writes (and improve stability with JDK-8 in 7.x).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>non-issue
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.14.1
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to ChunkedOutputStream we can optimize away small resumable uploads
to speed up small meta writes (and improve stability with JDK-8 in 7.x).
I think we should backport this to 7.14 as well to not regress on stability relative to 7.13.
closes #74739