Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Away Small Resumable Uploads in GCS Repository #74813

Conversation

original-brownbear
Copy link
Member

Similar to ChunkedOutputStream we can optimize away small resumable uploads
to speed up small meta writes (and improve stability with JDK-8 in 7.x).

I think we should backport this to 7.14 as well to not regress on stability relative to 7.13.

closes #74739

Similar to ChunkedOutputStream we can optimize away small resumable uploads
to speed up small meta writes (and improve stability with JDK-8 in 7.x).
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 1, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1 on 7.14

@original-brownbear
Copy link
Member Author

Thanks Tanguy!

@original-brownbear original-brownbear merged commit 85f0a02 into elastic:master Jul 1, 2021
@original-brownbear original-brownbear deleted the optimize-away-resumable-writes-gcs branch July 1, 2021 10:38
@fcofdez
Copy link
Contributor

fcofdez commented Jul 1, 2021

LTGM 2. Too quick for me this time :D

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 14, 2021
Similar to ChunkedOutputStream we can optimize away small resumable uploads
to speed up small meta writes (and improve stability with JDK-8 in 7.x).
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Aug 14, 2021
Similar to ChunkedOutputStream we can optimize away small resumable uploads
to speed up small meta writes (and improve stability with JDK-8 in 7.x).
original-brownbear added a commit that referenced this pull request Aug 14, 2021
)

Similar to ChunkedOutputStream we can optimize away small resumable uploads
to speed up small meta writes (and improve stability with JDK-8 in 7.x).
original-brownbear added a commit that referenced this pull request Aug 14, 2021
)

Similar to ChunkedOutputStream we can optimize away small resumable uploads
to speed up small meta writes (and improve stability with JDK-8 in 7.x).
@original-brownbear original-brownbear restored the optimize-away-resumable-writes-gcs branch April 18, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.14.1 v7.15.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] GoogleCloudStorageThirdPartyTests testCreateSnapshot failing
5 participants