Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move yml test to yamlRestTest directory #74689

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Move yml test to yamlRestTest directory #74689

merged 1 commit into from
Jun 30, 2021

Conversation

pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jun 29, 2021 •
edited
Loading

Percolator test was accidentally not moved to yamlRestTest directory
to be merged after #74698

@pgomulka pgomulka added the >test Issues or PRs that are addressing/adding tests label Jun 29, 2021
@pgomulka pgomulka self-assigned this Jun 29, 2021
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jun 29, 2021
@pgomulka
[Rest Api Compatibility] Types for Percolate Query Api
92afc0e 
Previously removed in elastic#46985. The yaml test is included in this PR, but
will be removed once elastic#74689 is merged.
@pgomulka pgomulka mentioned this pull request Jun 29, 2021
Merged
@pgomulka pgomulka requested a review from romseygeek June 30, 2021 07:10
romseygeek
romseygeek approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM.

pgomulka added a commit that referenced this pull request Jun 30, 2021
@pgomulka
[Rest Api Compatibility] Types for Percolate Query Api (#74698)
603ebf7 
Previously removed in #46985. The yaml test is included in this PR, but
will be removed once #74689 is merged.

relates #54160
relates main meta issue #51816
@pgomulka pgomulka merged commit 31b0b78 into elastic:7.x Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
>test Issues or PRs that are addressing/adding tests v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgomulka @romseygeek @elasticsearchmachine