Make test cluster tasks depend on fipsResources when fips enabled

[breskeby]

The fips specific cluster specification depends on files that are declared
as output of the fips-resources task. So far there has not been an explicit
dependency of all TestClustersAware tasks (so far only for Test tasks) to this
resources task in our build and.

implicit usage of task outputs without any explicit task dependency has been
deprecated in Gradle as the build tool detects that these file are outputs of
this task and urges users to have this explicit dependency declared in a build.

RestIntegTestTask had this dependencies explicitly declared by us having defined a dependency
by declaring

tasks.withType(Test) { dependsOn 'fipsResources'}.

This has be replaced by with this PR by

tasks.withType(TestClustersAware) { dependsOn 'fipsResources'}

which also covers usages of DefaultTestClustersTask as used in the
:x-pack:plugin:eql:qa:multi-cluster-with-security project which
fails in #74664

fixes #74664

[elasticmachine]

Pinging @elastic/es-delivery (Team:Delivery)

[breskeby]

@jkakavas @ywangd I've added you as reviewers but this is more an FYI. Will merge this as soon as passed the checks to unblock the failing fips builds again

[ywangd]

TIL. Thanks @breskeby 👍

[ywangd]

@breskeby I got a new failure on PR #74662 after merging the master branch. Failure message is something like:

Cannot change dependencies of dependency configuration ':x-pack:plugin:async-search:qa:security:es_distro_extracted_testclusters-x-pack-plugin-async-search-qa-security-javaRestTest-1-8.0.0-SNAPSHOT' after task dependencies have been resolved

Is it related to the changes introduced here?

Build scan: https://gradle-enterprise.elastic.co/s/ptphumjq27igu

[breskeby]

It shouldn't, but I'll look into this.

[breskeby]

This is not a a result of this PR. I see there are a few of those failures on ci the last few days. Is this reproducible for you?

[ywangd]

Thanks for looking into it. Sorry I assumed it could be due to this PR when seeing the words about dependencies.

Yes it is reproducible locally on the master branch with the followings:
./gradlew -Dtests.fips.enabled=true :example-plugins:custom-suggester:yamlRestTest
build scan: https://gradle-enterprise.elastic.co/s/x6b5p4sr7rely

[breskeby]

The other issue here raised by @ywangd is addressed by this PR: #74692

[elasticsearchmachine]

💔 Backport failed

Status	Branch	Result
❌	7.14	Commit could not be cherrypicked due to conflicts

To backport manually run:
backport --pr 74670