Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] SQL: Document null handling for functions #74444

Merged
merged 10 commits into from
Jun 23, 2021
Merged

[DOCS] SQL: Document null handling for functions #74444

merged 10 commits into from
Jun 23, 2021

Conversation

@jrodewig jrodewig changed the title [DOCS] SQL: Document null handling for aggregate functions [DOCS] SQL: Document null handling for functions Jun 22, 2021
@jrodewig jrodewig marked this pull request as ready for review June 23, 2021 12:53
@jrodewig jrodewig requested a review from matriv June 23, 2021 12:53
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team labels Jun 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

@matriv
Copy link
Contributor

matriv commented Jun 23, 2021

Regarding the date-time functions we also mention this in the description, for example: https://github.com/elastic/elasticsearch/pull/74444/files#diff-34118c3c46bec17c634fc5efa70c4ff0ff62e198a106564f175d1dae4d754447R705
(if one of the arguments is null then a null is returned)

Should we keep this as well ?

@jrodewig
Copy link
Contributor Author

Thanks for catching that @matriv. I've removed those statements from the date/time function docs with 1f9209a.

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jrodewig
Copy link
Contributor Author

Thanks @matriv!

@jrodewig jrodewig merged commit 47adf54 into elastic:master Jun 23, 2021
@jrodewig jrodewig deleted the docs__sql-fn-null-handling branch June 23, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/SQL SQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.12.2 v7.13.3 v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Document null/edge case handling for SQL functions
4 participants