RestController not using thread context directly from thread pool #74293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment thread context is passed via dispatchRequest but in some places thread context is fetched directly from thread pool This is not a problem in production, because thread pool is initialized with the same thread context as the one passed to dispatchRequest via AbstractHttpServerTransport. It might be harder to understand though and might cause problems in testing in smaller units.
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
original-brownbear
approved these changes
Jun 23, 2021
| .build(); | ||
| dispatchRequest(request); | ||
| assertWarnings(RestGetSourceAction.TYPES_DEPRECATION_MESSAGE); | ||
| for (RestRequest.Method method : Arrays.asList(RestRequest.Method.GET, RestRequest.Method.HEAD)) { |
There was a problem hiding this comment.
These test changes while nice aren't really related to the rest of the PR, maybe revert those to keep the change isolated?
There was a problem hiding this comment.
good idea, I will revert the test cases and will follow up in a separate PR
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jun 23, 2021
…astic#74293) At the moment thread context is passed via dispatchRequest but in some places thread context is fetched directly from thread pool This is not a problem in production, because thread pool is initialized with the same thread context as the one passed to dispatchRequest via AbstractHttpServerTransport. It might be harder to understand though and might cause problems in testing in smaller units.
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Jun 23, 2021
Refactoring RestGetActionTests and RestGestSourceActionTests to remove duplicated code. Previously the tests would fail if rest request was sent twice to RestController. This was fixed in elastic#74293 and the refactoring is possible now
pgomulka
added a commit
that referenced
this pull request
Jun 23, 2021
…kport(#74293) #74488 At the moment thread context is passed via dispatchRequest but in some places thread context is fetched directly from thread pool This is not a problem in production, because thread pool is initialized with the same thread context as the one passed to dispatchRequest via AbstractHttpServerTransport. It might be harder to understand though and might cause problems in testing in smaller units. backports #74293
pgomulka
added a commit
that referenced
this pull request
Jun 24, 2021
Refactoring RestGetActionTests and RestGestSourceActionTests to remove duplicated code. Previously the tests would fail if rest request was sent twice to RestController. This was fixed in #74293 and the refactoring is possible now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment thread context is passed via dispatchRequest but in some
places thread context is fetched directly from thread pool
This is not a problem in production, because thread pool is initialized
with the same thread context as the one passed to dispatchRequest via
AbstractHttpServerTransport.
It might be harder to understand though and might cause problems in
testing in smaller units.
relates #74230 (comment)