Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Type metadata for docs used in simulate request #74222

Merged
merged 4 commits into from
Jun 21, 2021
Merged

[Rest Api Compatibility] Type metadata for docs used in simulate request #74222

merged 4 commits into from
Jun 21, 2021

Conversation

pgomulka
Copy link
Contributor

This commit allows to provide _type field on document ingested in
simulate pipeline requests.

relates main meta issue #51816
relates types removal issue #54160

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Type metadata for docs used in simulate request
4c15725 
This commit allows to provide _type field on document ingested in
simulate pipeline requests.

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels Jun 17, 2021
@pgomulka pgomulka self-assigned this Jun 17, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jun 17, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka pgomulka requested a review from romseygeek June 17, 2021 14:51
romseygeek
romseygeek approved these changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka
Copy link
Contributor Author

@elasticmachine update branch

@pgomulka pgomulka merged commit 073f080 into elastic:master Jun 21, 2021
@pgomulka pgomulka mentioned this pull request Jun 24, 2021
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @romseygeek @jakelandis