Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Community ID processor in Painless #73963

Merged

Conversation

danhermann
Copy link
Contributor

Adds two Processors.communityId() methods to Painless that exposes the functionality of the community ID processor.

Relates to #73346

@danhermann danhermann added >enhancement :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.14.0 labels Jun 9, 2021
@danhermann danhermann marked this pull request as ready for review June 9, 2021 18:34
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Jun 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@probakowski probakowski self-requested a review June 10, 2021 15:44
@danhermann
Copy link
Contributor Author

@probakowski, I've updated this one with your suggestions in 9c49328

Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise LGTM 👍 Thanks, Dan!

if (flow == null) {
if (ignoreMissing) {
return ingestDocument;
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should still be here?

@danhermann
Copy link
Contributor Author

Thanks, @probakowski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants