Deprecations for single data node setting #73733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In elastic#55805, we added a setting to allow single data node clusters to respect the high watermark. This commit adds deprecation warnings to 7.x to ensure we can make only true valid in 8.0.
henningandersen
added
:Distributed Coordination/Allocation
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Jun 3, 2021
In elastic#55805, we added a setting to allow single data node clusters to respect the high watermark. In elastic#73733 we added the related deprecations. This commit ensures the only valid value for the setting is true and adds deprecations if the setting is set. The setting will be removed in a future release.
DaveCTurner
reviewed
Jun 4, 2021
There was a problem hiding this comment.
Similarly to #73737 (comment), if the cluster has a single data node then should we emit deprecation logs even if cluster.routing.allocation.disk.watermark.enable_for_single_data_node is unset?
henningandersen
requested review from
DaveCTurner
and removed request for
DaveCTurner
|
I think such a deprecation warning would be annoying to 99%+ of users. I wonder if a compromise could be to let the deprecation info check depend on number of data nodes in the cluster and emit the deprecation issue if the setting is unset in a single data node cluster? |
|
++ that's what I meant by
😁 |
DaveCTurner
approved these changes
Jun 7, 2021
| @@ -41,7 +44,7 @@ | |||
|
|
|||
| class NodeDeprecationChecks { | |||
|
|
|||
| static DeprecationIssue checkPidfile(final Settings settings, final PluginsAndModules pluginsAndModules) { | |||
| static DeprecationIssue checkPidfile(final Settings settings, final PluginsAndModules pluginsAndModules, ClusterState cs) { | |||
There was a problem hiding this comment.
Nit, for consistency I'd prefer this (and similarly below too)
Suggested change
| static DeprecationIssue checkPidfile(final Settings settings, final PluginsAndModules pluginsAndModules, ClusterState cs) { | |
| static DeprecationIssue checkPidfile(final Settings settings, final PluginsAndModules pluginsAndModules, final ClusterState clusterState) { |
I'm ok with state instead of clusterState although I prefer the latter.
There was a problem hiding this comment.
Yeah, I agree, I was too lazy.....
Co-authored-by: David Turner <[email protected]>
|
Thanks David! |
henningandersen
added a commit
that referenced
this pull request
Jun 7, 2021
In #55805, we added a setting to allow single data node clusters to respect the high watermark. In #73733 we added the related deprecations. This commit ensures the only valid value for the setting is true and adds deprecations if the setting is set. The setting will be removed in a future release. Co-authored-by: David Turner <[email protected]>
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Sep 2, 2021
The deprecation warning for relying on the default value for `cluster.routing.allocation.disk.watermark.enable_for_single_data_node` was marked critical, but upgrading should never fail due to this. Now changed to a warning. Relates elastic#73733
henningandersen
added a commit
that referenced
this pull request
Sep 2, 2021
The deprecation warning for relying on the default value for `cluster.routing.allocation.disk.watermark.enable_for_single_data_node` was marked critical, but upgrading should never fail due to this. Now changed to a warning. Relates #73733
henningandersen
added a commit
that referenced
this pull request
Sep 2, 2021
The deprecation warning for relying on the default value for `cluster.routing.allocation.disk.watermark.enable_for_single_data_node` was marked critical, but upgrading should never fail due to this. Now changed to a warning. Relates #73733
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 7, 2024
…ata_node` setting Prior to 7.8, whenever a cluster had only a single data node, the watermarks would not be respected. This was incompatible with how storage based autoscaling on ESS/ECH works and in order to change this in 7.8+ in a backwards compatible way, we had to introduce the `cluster.routing.allocation.disk.watermark.enable_for_single_data_node node` setting. The setting was deprecated in elastic#73733 (7.14), and was made to accept only `true` in elastic#73737 (8.0).
arteam
added a commit
to arteam/elasticsearch
that referenced
this pull request
Oct 7, 2024
…ata_node` setting Prior to 7.8, whenever a cluster had only a single data node, the watermarks would not be respected. This was incompatible with how storage based autoscaling on ESS/ECH works and in order to change this in 7.8+ in a backwards compatible way, we had to introduce the `cluster.routing.allocation.disk.watermark.enable_for_single_data_node node` setting. The setting was deprecated in elastic#73733 (7.14), and was made to accept only `true` in elastic#73737 (8.0).
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 6, 2024
…ata_node` setting (#114207) Prior to 7.8, whenever a cluster had only a single data node, the watermarks would not be respected. This was incompatible with how storage based autoscaling works and in order to change this in 7.8+ in a backwards compatible way, we had to introduce the `cluster.routing.allocation.disk.watermark.enable_for_single_data_node node` setting. The setting was deprecated in #73733 (7.14), and was made to accept only `true` in #73737 (8.0).
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
…ata_node` setting (#114207) Prior to 7.8, whenever a cluster had only a single data node, the watermarks would not be respected. This was incompatible with how storage based autoscaling works and in order to change this in 7.8+ in a backwards compatible way, we had to introduce the `cluster.routing.allocation.disk.watermark.enable_for_single_data_node node` setting. The setting was deprecated in #73733 (7.14), and was made to accept only `true` in #73737 (8.0).
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…ata_node` setting (elastic#114207) Prior to 7.8, whenever a cluster had only a single data node, the watermarks would not be respected. This was incompatible with how storage based autoscaling works and in order to change this in 7.8+ in a backwards compatible way, we had to introduce the `cluster.routing.allocation.disk.watermark.enable_for_single_data_node node` setting. The setting was deprecated in elastic#73733 (7.14), and was made to accept only `true` in elastic#73737 (8.0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #55805, we added a setting to allow single data node clusters to
respect the high watermark. This commit adds deprecation warnings to 7.x
to ensure we can make only true valid in 8.0.