Add cross cluster support to _terms_enum #73478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the support to search cross cluster indices (with the cross cluster syntax) in the _terms_enum API. Relates elastic#71550
jimczi
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
jimczi
commented
May 27, 2021
...n/core/src/main/java/org/elasticsearch/xpack/core/termsenum/action/NodeTermsEnumRequest.java
Show resolved
Hide resolved
jimczi
commented
May 27, 2021
...n/core/src/main/java/org/elasticsearch/xpack/core/termsenum/action/NodeTermsEnumRequest.java
Outdated
Show resolved
Hide resolved
jimczi
commented
May 27, 2021
| if (lastTerm != null && results.size() < request.size()) { | ||
| results.add(lastTerm.getTerm()); | ||
| } | ||
|
|
There was a problem hiding this comment.
I ended up rewriting the logic to do a merge sort with a priority queue. The change is small but I can open a dedicated PR if that's preferred.
markharwood
approved these changes
Jun 2, 2021
...uster-search-security/src/test/resources/rest-api-spec/test/multi_cluster/120_terms_enum.yml
Show resolved
Hide resolved
...re/src/main/java/org/elasticsearch/xpack/core/termsenum/action/TransportTermsEnumAction.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/elasticsearch/xpack/core/termsenum/action/TransportTermsEnumAction.java
Outdated
Show resolved
Hide resolved
jtibshirani
approved these changes
Jun 7, 2021
|
|
||
| public NodeTermsEnumRequest(StreamInput in) throws IOException { | ||
| super(in); | ||
| field = in.readString(); | ||
| string = in.readString(); | ||
| string = in.readOptionalString(); |
There was a problem hiding this comment.
Not for this PR, but it'd be good to have unit tests like NodeTermsEnumRequestTests and TermsEnumRequestTests that extend AbstractWireSerializingTestCase, like we have for other requests.
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Jun 9, 2021
This commit adds the support to search cross cluster indices (with the cross cluster syntax) in the _terms_enum API. Relates elastic#71550
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the support to search cross cluster indices (with the cross cluster syntax)
in the _terms_enum API.
This PR is marked as a non-issue since the API is new in 7.14.
Relates #71550