Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Update alias security for data stream aliases #73436

Merged
merged 3 commits into from
May 27, 2021
Merged

[DOCS] Update alias security for data stream aliases #73436

merged 3 commits into from
May 27, 2021

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented May 26, 2021 •
edited
Loading

In 7.14+, you can create data stream aliases. This updates the related
security documentation. It also streamlines the docs to remove redundant examples.

Previews

@jrodewig jrodewig mentioned this pull request May 26, 2021
Closed
8 tasks
@jrodewig
[DOCS] Update alias security for data stream aliases
45cf97f 
In 7.14+, you can now create data stream aliases. This updates the related
 security documentation. It also streamlines the docs to remove redundant
 examples.
@jrodewig jrodewig marked this pull request as ready for review May 26, 2021 20:42
@jrodewig jrodewig added :Data Management/Indices APIs APIs to create and manage indices and templates :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC labels May 26, 2021
@jrodewig jrodewig requested a review from albertzaharovits May 26, 2021 20:43
@elasticmachine elasticmachine added Team:Security Meta label for security team Team:Data Management Meta label for data/management team labels May 26, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

@jrodewig jrodewig requested review from ywangd and martijnvg May 26, 2021 20:43
martijnvg
martijnvg approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ywangd
ywangd approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x-pack/docs/en/security/authorization/alias-privileges.asciidoc Outdated
a data stream. Any role or user granted privileges to a data
stream are automatically granted the same privileges to its backing indices.
Use <<privileges-list-indices,index privileges>> to control access to a data
stream. Any role or user granted privileges to a data stream are automatically
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware this is existing sentence, but I don't quite follow it, especially the "Any role or user granted prvileges" part. I think it means granting any privileges for a datastream cascades down to its backing indices. But it's unclear to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising this. Your understanding is correct. I reworded this to:

Granting privileges for a data stream grants the same privileges for its backing indices.

x-pack/docs/en/security/authorization/alias-privileges.asciidoc
// NOTCONSOLE

[discrete]
==== Managing aliases
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this section is removed because similar information is available on the alias page? Can we add a link here again to say something like "please see here for how to manage alias"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. I'll add the following sentence to the intro:

For information about managing aliases, see <>.

@jrodewig
Copy link
Contributor Author

Thanks @martijnvg @ywangd.

@jrodewig jrodewig merged commit cd15214 into elastic:master May 27, 2021
@jrodewig jrodewig deleted the docs__update-alias-security branch May 27, 2021 13:29
@jrodewig jrodewig mentioned this pull request May 27, 2021
Merged
jrodewig added a commit that referenced this pull request May 27, 2021
@jrodewig
[DOCS] Update alias security for data stream aliases (#73436) (#73477)
416558b 
In 7.14+, you can create data stream aliases. This updates the related security documentation. It also streamlines the docs to remove redundant examples.
limingnihao added a commit to limingnihao/elasticsearch that referenced this pull request May 28, 2021
@limingnihao
Merge branch 'master' into custom
209e049 
* master: (1643 commits)
  Make DataStreamsSnapshotsIT resilient to failures because of local time. (elastic#73516)
  Upgrade netty to 4.1.63 (elastic#73011)
  [DOCS] Create a new page for dissect content in scripting docs (elastic#73437)
  Deprecate freeze index API (elastic#72618)
  [DOCS] Remove 'closed data stream' reference
  [DOCS] Update alias references (elastic#73427)
  [DOCS]  Create a new page for grok content in scripting docs (elastic#73118)
  Remove dependency on azure shadowjar since it's no longer required
  [DOCS] Update backport policy for known issues (elastic#73489)
  Shadowed dependencies should be hidden from pom dependencies (elastic#73467)
  Disable transitive dependencies when resolving bwc JDBC driver artifact (elastic#73448)
  Print full JVM implementation version at start of build (elastic#73439)
  [DOCS] Update snapshot/restore for data stream aliases (elastic#73438)
  Upgrade Azure SDK and Jackson (elastic#72833) (elastic#72995)
  [DOCS] Fix typo (elastic#73337) (elastic#73474)
  [DOCS] Fix typo (elastic#73444) (elastic#73472)
  [DOCS] Update alias security for data stream aliases (elastic#73436)
  Fix Bug with Concurrent Snapshot and Index Delete (elastic#73456)
  [DOCS] Move common scripting use cases up a level (elastic#73445)
  Add more validation for data stream aliases. (elastic#73416)
  ...
@probakowski probakowski added the >docs General docs changes label Jul 30, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jul 30, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywangd ywangd ywangd approved these changes

@martijnvg martijnvg martijnvg approved these changes

@albertzaharovits albertzaharovits Awaiting requested review from albertzaharovits

Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates >docs General docs changes :Security/Authorization Roles, Privileges, DLS/FLS, RBAC/ABAC Team:Data Management Meta label for data/management team Team:Docs Meta label for docs team Team:Security Meta label for security team v7.14.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jrodewig @elasticmachine @martijnvg @ywangd @jakelandis @probakowski