Adding tests for deprecation message when a REST wrapper implementing plugin presents (#66827) #73329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine update branch |
-Test the right deprecation message logged when custom security plugin installs rest handler -Test no deprecation message logged when elastic Security plugin installs rest handler
BigPandaToo
added
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
tvernum
reviewed
May 27, 2021
test/framework/src/main/java/org/elasticsearch/test/ESTestCase.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/XPackPluginTests.java
Outdated
Show resolved
Hide resolved
...ernalClusterTest/java/org/elasticsearch/xpack/security/SecurityPluginNoDeprecationTests.java
Outdated
Show resolved
Hide resolved
test/framework/src/main/java/org/elasticsearch/test/ESIntegTestCase.java
Outdated
Show resolved
Hide resolved
...ernalClusterTest/java/org/elasticsearch/xpack/security/SecurityPluginNoDeprecationTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
@elasticmachine update branch |
-Test the right deprecation message logged when custom security plugin installs rest handler -Test no deprecation message logged when elastic Security plugin installs rest handler
tvernum
reviewed
Jun 9, 2021
server/src/test/java/org/elasticsearch/action/ActionModuleTests.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/Security.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
|
tvernum
requested changes
Jun 15, 2021
server/src/test/java/org/elasticsearch/action/ActionModuleTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine update branch |
BigPandaToo
changed the title
BigPandaToo
changed the title
|
Sorry, forgot to commit half of the change －ლ |
tvernum
approved these changes
Jun 16, 2021
| @@ -234,4 +228,11 @@ public void testCustomRestWrapperDeprecationMessage() { | |||
| public void handleRequest(RestRequest request, RestChannel channel, NodeClient client) throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| class SecPlugin implements ActionPlugin { | |||
There was a problem hiding this comment.
Nit: I don't think the abbreviation helps here - why Sec rather than Security ?
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 7.13 we added a deprecation message when a security REST
wrapper implementing plugin presents.
This change adding tests to:
-Test the right deprecation message logged when custom
security plugin installs rest handler
-Test no deprecation message logged when elastic Security
plugin installs rest handler