Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix SearchableSnapshotsPersistentCacheIntegTests.testPersistentCacheCleanUpAfterRelocation #73207

Merged
merged 1 commit into from
May 19, 2021

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented May 18, 2021

On 7.x the test should always use soft deletes because
peer recovery always copies .liv files but searchable
snapshot directories do not support writing files,
preventing the shard to be relocated (and times out).

Relates #55142
Closes #72857

…CacheCleanUpAfterRelocation

On 7.x the test should always use soft deletes because
peer recovery always copies .liv files but searchable
snapshot directories do not support writing files.

Relates elastic#55142
Closes elastic#72857
@tlrx tlrx added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.14.0 v7.13.1 labels May 18, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label May 18, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@tlrx tlrx requested a review from DaveCTurner May 19, 2021 07:03
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlrx tlrx merged commit 3627275 into elastic:7.x May 19, 2021
@tlrx tlrx deleted the always-use-soft-deletes branch May 19, 2021 08:45
@tlrx
Copy link
Member Author

tlrx commented May 19, 2021

Thanks David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.13.1 v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants