Fix Edge-Case Threading Bug in TransportMountSearchableSnapshotAction #73196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback to loading the repository-data may not run on generic in the uncached case because of the repo data deduplication logic. The same issue was fixed for the snapshot status API in elastic#68023
original-brownbear
added
>bug
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| @@ -280,6 +280,6 @@ protected void masterOperation( | |||
| .snapshotUuid(snapshotId.getUUID()), | |||
| listener | |||
| ); | |||
| }, listener::onFailure); | |||
| }, listener::onFailure), threadPool.generic(), null); | |||
There was a problem hiding this comment.
As discussed in #73172 we could use the new snapshot meta pool here to limit concurrency of this operation. I think it makes sense to do that.
You mean in the repository? The annoying thing about that is that it may cause a number of needless context switches where we don't actually have to fork off. But maybe with the new pool that's ok and we could always switch to it even if it causes some needless switches. For now I just made this thing fork to the new pool though. |
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jun 29, 2021
…elastic#73196) The callback to loading the repository-data may not run on generic in the uncached case because of the repo data deduplication logic. The same issue was fixed for the snapshot status API in elastic#68023
original-brownbear
added a commit
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback to loading the repository-data may not run on generic in the uncached case
because of the repo data deduplication logic.
The same issue was fixed for the snapshot status API in #68023