Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rest Api Compatibility] Typed endpoints for RestUpdateAction and RestDeleteAction #73115

Merged
merged 1 commit into from
May 18, 2021
Merged

[Rest Api Compatibility] Typed endpoints for RestUpdateAction and RestDeleteAction #73115

merged 1 commit into from
May 18, 2021

Conversation

pgomulka
Copy link
Contributor

the previously removed typed enpotins for Update and Delete are
retrofitted in this commit
the commit that removed them
#47671

relates main meta issue #51816
relates types removal issue #54160

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
[Rest Api Compatibility] Typed endpoints for RestUpdateAction and Res…
0071ea2 
…tDeleteAction

the previously removed typed enpotins for Update and Delete are
retrofitted in this commit
the commit that removed them
elastic#47671

relates main meta issue elastic#51816
relates types removal issue elastic#54160
@pgomulka pgomulka self-assigned this May 14, 2021
@pgomulka pgomulka added :Core/Infra/REST API REST infrastructure and utilities v8.0.0 labels May 14, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label May 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@romseygeek romseygeek mentioned this pull request May 17, 2021
Merged
romseygeek
romseygeek approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgomulka pgomulka merged commit d5bf72a into elastic:master May 18, 2021
@pgomulka pgomulka mentioned this pull request May 24, 2021
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romseygeek romseygeek romseygeek approved these changes

@jakelandis jakelandis Awaiting requested review from jakelandis

@joegallo joegallo Awaiting requested review from joegallo

@jtibshirani jtibshirani Awaiting requested review from jtibshirani

Assignees
No one assigned
Labels
:Core/Infra/REST API REST infrastructure and utilities >enhancement Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgomulka @elasticmachine @romseygeek @jakelandis