Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release memory held by aggs on failure #72966

Conversation

henningandersen
Copy link
Contributor

If consuming a query result were disrupted by circuit breaker we would
leak memory for aggs in buffered query results, fixed.

Relates #62439 and #72309

If consuming a query result were disrupted by circuit breaker we would
leak memory for aggs in buffered query results, fixed.

Relates elastic#62439 and elastic#72309
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label May 12, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for tracking this down so quickly :)

@iverase
Copy link
Contributor

iverase commented May 12, 2021

This should address #72923 as well

@henningandersen henningandersen merged commit 9ab8fc5 into elastic:master May 12, 2021
henningandersen added a commit that referenced this pull request May 12, 2021
If consuming a query result were disrupted by circuit breaker we would
leak memory for aggs in buffered query results, fixed.

Relates #62439 and #72309

Closes #72923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.14.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants